feat(twilio-run): upgrading serverless-runtime-types #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2023 12:11
fixed typing issues that arose from using the upgraded package
Cookies are stored with a value and optional list of attributes
🦋 Changeset detectedLatest commit: ad52bb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
added changeset
andrewbenington
changed the title
andrewbenington
changed the title
|
Hi @andrewbenington, thank you for submitting a PR to the serverless toolkit. At this time, it's unlikely we will be able to merge feature PRs for at least the near future. I'd like to keep this open since it's a good start at a needed improvement, but there are some things that would need to be addressed before merging this when the time comes. Thanks again for taking the time to contribute a PR and apologies that we cannot move forward at present! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serverless-runtime-typesin thetwilio-runpackageResponseclass, as well assetCookieandremoveCookiefunctions in order to fully implement theTwilioResponseinterfaceconstructContextfunction of routes.ts, I had to explicitly include theSERVICE_SIDandENVIRONMENT_SIDattributes ofenvdue toenvbeing typed asanyServerlessEventObjectas the type parameter for an invocation ofconstructContextContributing to Twilio